[PATCH] D28459: Make processing @llvm.assume more efficient - Add affected values to the assumption cache

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Analysis/AssumptionCache.cpp:59-63
+  Value *Cond = CI->getArgOperand(0), *A, *B;
+  AddAffected(Cond);
+
+  CmpInst::Predicate Pred;
+  if (match(Cond, m_ICmp(Pred, m_Value(A), m_Value(B)))) {
----------------
Prazek wrote:
> A and B are undefined, and they are not assigned in m_Value, so what is going on here?
> I am just not familiar with this matcher library, but it looks very odd.
They are assigned in m_Value (as in the example at the very top of include/llvm/IR/PatternMatch.h). You might be thinking of m_Specific, which matches a specific provided value.



https://reviews.llvm.org/D28459