[PATCH] D28234: Support for custom install dirs in CMake build

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 05:36:36 PST 2017


mgorny added inline comments.


================
Comment at: CMakeLists.txt:305
+    CACHE STRING "Path for include directory relative to CMAKE_INSTALL_PREFIX (defaults to 'include'" )
+set(CMAKE_INSTALL_DOCDIR share/doc/${project}
+    CACHE STRING "Path for documentation directory relative to CMAKE_INSTALL_PREFIX (defaults to 'share/doc/${project}')" )
----------------
nalimilan wrote:
> beanz wrote:
> > This is also bad for similar reasons as above.
> Is there a reason to use `${project}` here instead of just `llvm`?
Yes. Those paths were used in e.g. clang, and there project evaluated to clang. At least for stand-alone builds, that is. 


Repository:
  rL LLVM

https://reviews.llvm.org/D28234





More information about the llvm-commits mailing list