[PATCH] D28481: Respect section groups in GC

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Hm, now I recall why we did that for C identifier sections. Sections with C identifier names can be garbage collected if no one is referring them, but that cannot be determined until we create output sections, and when we create output sections, it is usually too late to do GC. We could do something tricky to handle that, but it's probably not worth it.

So, maybe I'm fine with this. But I think the implementation can be simplified. It feels it is doing too much ahead of time. Also the new condition `Sec->GroupSections.size() == 0 && isValidCIdentifier(S)` definitely needs a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D28481