[PATCH] D28486: Add TypeDatabase

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

This looks pretty good to me.



================
Comment at: llvm/lib/DebugInfo/CodeView/TypeDatabase.cpp:25
+/// StringRef.
+static const SimpleTypeEntry SimpleTypeNames[] = {
+    {"void*", SimpleTypeKind::Void},
----------------
Should these use the same .def file trick used in so many other places with large tables like this?


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeDatabase.cpp:70
+TypeIndex TypeDatabase::getNextTypeIndex() const {
+  return TypeIndex(0x1000 + CVUDTNames.size());
+}
----------------
Maybe use TypeIndex::FirstNonSimpleIndex for these.

I know the value isn't likely to change, but it could be a good breadcrumb for the uninitiated to discover why this 0x1000 base value exists.


https://reviews.llvm.org/D28486