[PATCH] D28337: [InstSimplify] if the condition of a select is known, eliminate the select

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I hope I'm not burning everyone out with 'assume' questions, but I should mention that the test in https://reviews.llvm.org/D28485 works because we have a naked call to computeKnownBits() in InstCombiner::visitReturn(). I'm guessing that there are usually less 'ret' insts than 'select' insts, but should that fold be guarded in the same way as we decide here?

  // There might be assume intrinsics dominating this return that completely
  // determine the value. If so, constant fold it.


https://reviews.llvm.org/D28337