[PATCH] D28490: [LV] Don't panic when encountering the IV of an outer loop.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 15:31:57 PST 2017

Previous message: [PATCH] D28490: [LV] Don't panic when encountering the IV of an outer loop.
Next message: [PATCH] D28490: [LV] Don't panic when encountering the IV of an outer loop.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

sanjoy added a comment.

I can't really review the code; but, did you consider writing the test case in C++ (inside unittests/)?  Relying on LICM to create just the right preconditions seems somewhat fragile (that is, it is possible that a future change to LICM will make this test a no-op).


https://reviews.llvm.org/D28490

Previous message: [PATCH] D28490: [LV] Don't panic when encountering the IV of an outer loop.
Next message: [PATCH] D28490: [LV] Don't panic when encountering the IV of an outer loop.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list