[PATCH] D28487: Fixup test to accept different Opcode values

Douglas Yung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 14:49:41 PST 2017


dyung created this revision.
dyung added reviewers: t.p.northover, sanjoy.
dyung added a subscriber: llvm-commits.

The test is searching for a specific opcode when it doesn't really need to. This causes a problem when the opcode changes for whatever reason, so update the test with a change similar to r274774 to make the test more robust.


https://reviews.llvm.org/D28487

Files:
  test/CodeGen/X86/implicit-null-checks.mir


Index: test/CodeGen/X86/implicit-null-checks.mir
===================================================================
--- test/CodeGen/X86/implicit-null-checks.mir
+++ test/CodeGen/X86/implicit-null-checks.mir
@@ -319,7 +319,7 @@
   - { reg: '%rsi' }
 # CHECK:  bb.0.entry:
 # CHECK:  %rbx = MOV64rr %rdx
-# CHECK-NEXT:  %rdi = FAULTING_LOAD_OP %bb.3.is_null, 260, killed %rbx, killed %rdi, 1, _, 0, _, implicit-def dead %eflags :: (load 4 from %ir.x)
+# CHECK-NEXT:  %rdi = FAULTING_LOAD_OP %bb.3.is_null, {{[0-9]+}}, killed %rbx, killed %rdi, 1, _, 0, _, implicit-def dead %eflags :: (load 4 from %ir.x)
 
 body:             |
   bb.0.entry:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28487.83708.patch
Type: text/x-patch
Size: 643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170109/aee3d31d/attachment.bin>


More information about the llvm-commits mailing list