[PATCH] D27807: [globalisel] Initialize RegisterBanks with static data. Part 1 of 2.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/RegisterBankInfo.cpp:188
+  RB.dump(&TRI);
+  llvm_unreachable("Please call setRegBankData() and setRegBankCoverage() instead");
+}
----------------
qcolombet wrote:
> dsanders wrote:
> > qcolombet wrote:
> > > Shouldn't we just delete this API instead?
> > That's done in the next patch. It's been kept in this patch so that any targets that aren't migrated by this patch yet will dump the information needed to migrate instead of just failing to link.
> Let's just squash the two part of this patch.
> I expect that people would look at the commit list to understand why this method disappeared. Just add that information in the commit message.
Ok. Other targets won't be able to apply a few s///'s to the dump to create the tables like I did but I suppose we can always point them at this version of the patch if we need to.


https://reviews.llvm.org/D27807