[PATCH] D28386: Add the ability to iterate across all attributes in a DIE.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 14:24:02 PST 2017


clayborg marked 3 inline comments as done.
clayborg added a comment.

Marked things as done.



================
Comment at: unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:1271
+  Error Err = Error::success();
+  for (auto &AttrValue : CUDie.attributes(&Err)) {
+    switch (AttrValue.Attr) {
----------------
This might be awkward, but it is how users will use it and this verifies things come out in order. I would rather test this like users will test it rather than use the range manually since this tests everything that the iterator needs.


https://reviews.llvm.org/D28386





More information about the llvm-commits mailing list