[PATCH] D28436: [Sanitizer Coverage] Modify initialization of array bounds for sanitizer coverage.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 13:40:14 PST 2017


rnk added a comment.

I think we want to ensure that these globals end up in .bss on non-Windows platforms. It saves a lot of object file and binary size to keep them in .bss. In the worst case, we may need to make the initializer platform-dependent. However, before we do that, are you sure the sanitizer runtime can't tolerate extra padding in this array? Is it a problem if some of the guard "pcs" are wasted on padding? It's worth discussing this in person with Kostya to figure this out. It would also be nice if this could live in .bss on Windows as well as Linux.


Repository:
  rL LLVM

https://reviews.llvm.org/D28436





More information about the llvm-commits mailing list