[PATCH] D28369: Refactor inline threshold update code.

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 13:33:47 PST 2017


eraman added a comment.

In https://reviews.llvm.org/D28369#639863, @chandlerc wrote:

> This LGTM, but please make sure you update the changed escription to explain exactly what all is changing here. For example with the cold vs. minsize, I think it's safe, and we can't even really usefully test it as in tree this never happens. But you may need to explain to people that if they *do* have a crazy minsize vs. cold threshold, they may need to fix them now.
>
> Thanks for the refactoring!


Thanks. I've updated the description.


https://reviews.llvm.org/D28369





More information about the llvm-commits mailing list