[PATCH] D28470: Support outputting to /dev/null

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama <ruiu at google.com> writes:

>> > You want to call this only when IsRegular.
>>
>> Why? It is a good think to remove the temporary file in both cases.
>>
>
> Sorry, I misunderstood the code. This part looks fine.
>
> But why do you call DontRemoveFileOnSignal on commit()? I think you want to
> remove a temporary file on commit.

Yes. I will update the patch.

> Does sys::fs::rename() work on two paths that reside in different
> filesystems? The comment for the function says that it uses POSIX rename(),
> which I believe doesn't work across filesystems.

It doesn't work. That is why the patch uses copy in the non-regular
case.

Cheers,
Rafael