[PATCH] D28337: [InstSimplify] if the condition of a select is known, eliminate the select

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 12:31:25 PST 2017


majnemer added a comment.

In https://reviews.llvm.org/D28337#640118, @efriedma wrote:

> This seems like a dangerous direction, in the sense that it could make instsimplify very expensive... I mean, if we didn't care about compile-time cost, we could call computeKnownBits on all the operands for every call into instsimplify, and hope something simplifies.  Could we put this sort of transform somewhere it isn't called so frequently?


I agree, I'm not sure this is the right place for this.


https://reviews.llvm.org/D28337





More information about the llvm-commits mailing list