[PATCH] D28453: SimplifyLibCalls: Remove checks for fabs
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 11:57:20 PST 2017
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with a minor tweak.
> There are some additional places using this like ConstantFolding that may want to stay
I don't see why this would be worth keeping. instcombine will transform fabs(const)->llvm.fabs(const)->const.
================
Comment at: test/Transforms/InstCombine/win-math.ll:277
declare float @powf(float, float)
; win32 lacks sqrtf&fabsf, win64 lacks fabsf
define float @float_powsqrt(float %x) nounwind readnone {
----------------
Update this comment to reflect the fact that we aren't calling fabsf?
https://reviews.llvm.org/D28453
More information about the llvm-commits
mailing list