[PATCH] D28456: DebugInfo: support for DW_FORM_implicit_const
Victor Leschuk via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 11:30:35 PST 2017
vleschuk added inline comments.
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAbbreviationDeclaration.h:34-38
/// contained in or the value size varies and must be decoded from the
/// debug information in order to determine its size.
Optional<uint8_t> ByteSize;
+ /// Optional value (for DW_FORM_implicit_const).
+ Optional<int64_t> Value;
----------------
dblaikie wrote:
> These are mutually exclusive, right? (if there's a value, the byte size is zero) - could we coalesce them in some way?
We could use simply int64_t and bool field, smth like:
```
int64_t ByteSizeOrValue;
bool IsImplicitConst;
```
But will it gain us much?
https://reviews.llvm.org/D28456
More information about the llvm-commits
mailing list