[PATCH] D28429: Remove the restriction of ten types on AligedCharArrayUnion

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D28429#640011, @spyffe wrote:

> According to the GCC 5 changelist <https://gcc.gnu.org/gcc-5/changes.html>, support for `std::aligned_union` was introduced with GCC 5.
>  I was able to verify with Compiler Explorer <http://gcc.godbolt.org> that `std::aligned_union` is **unsupported** (as in, not found) by 4.9.5. It is supported by 5.1.


Oh, too bad.

> According to Microsoft <https://msdn.microsoft.com/en-us/library/dn986846.aspx>, Visual Studio 2015 supports `std::aligned_union`.
>  I was able to verify with "Compile Visual Studio C++ Online" <http://rextester.com/l/cpp_online_compiler_visual> that Visual C++ 2015 supports it.

Thanks for checking.

I'm fine with this going in as long as David is happy.


https://reviews.llvm.org/D28429