[PATCH] D28470: Support outputting to /dev/null

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Support/FileOutputBuffer.cpp:63
         return EC;
       else
+        IsRegular = false;
----------------
Remove `else`.


================
Comment at: lib/Support/FileOutputBuffer.cpp:74
 
   // Create new file in same directory but with random name.
   SmallString<128> TempFilePath;
----------------
Update the comment.


================
Comment at: lib/Support/FileOutputBuffer.cpp:92
 
   sys::RemoveFileOnSignal(TempFilePath);
 
----------------
You want to call this only when IsRegular.


https://reviews.llvm.org/D28470