[PATCH] D28335: [WIP] [RFC] Don't lower floating point intrinsics to libcalls which modify errno

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 10:33:23 PST 2017


efriedma added a comment.

> Should https://reviews.llvm.org/D27618 be abandoned and we instead pursue this approach?

Probably, yes...

Actually, just fixing sqrt() on its own is substantially simpler than fixing all the other functions: we can lower llvm.sqrt() to "x < 0 ? NaN : sqrt(x)" if necessary, since that never sets errno.  (We probably want to try to avoid generating that sequence if possible, but it would only be relevant on soft-float Linux targets, so maybe not a big deal.)


Repository:
  rL LLVM

https://reviews.llvm.org/D28335





More information about the llvm-commits mailing list