[PATCH] D28105: [DWARF] - Introduce DWARFCompression class.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 10:20:18 PST 2017


David Blaikie via Phabricator <reviews at reviews.llvm.org> writes:

> dblaikie added inline comments.
>
>
> ================
> Comment at: include/llvm/DebugInfo/DWARF/DWARFCompression.h:21
> +/// This class helps to handle decompression of compressed debug sections.
> +class DWARFCompression {
> +public:
> ----------------
> Slightly odd/non-descript name (DWARFDecompressor? it seems specifically for decompressing)

Having "DWARF" in it is probably also wrong. Any section can be
compressed. This is normally used for debug info, but it should probably
not show up in the name.

Cheers,
Rafael


More information about the llvm-commits mailing list