[PATCH] D27751: [LLVM] Use after move bug fixes

[Martin Böhme via Phabricator via llvm-commits]

mboehme added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:27000
   while (Mask.size() > 1 && canWidenShuffleElements(Mask, WidenedMask)) {
+    // No use after move, WidenMask reinitialized in canWidenShuffleElements.
     Mask = std::move(WidenedMask);
----------------
Prazek wrote:
> mboehme wrote:
> > Typo: Should be WidenedMask
> btw, why it fires here? It is passed to canWidenShuffleElements by reference and documentation says that it assumes it is being reinitialized in this case.
You're right, it shouldn't fire here. I'll take a look at what's going wrong here.


https://reviews.llvm.org/D27751