[PATCH] D28455: [X86] Fix PR30926 - Add patterns for optimizing cvtsi2ss, cvtsi2sd, cvtsd2ss and cvtss2sd clang intrinsic sequences

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 05:26:02 PST 2017


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrSSE.td:1962
+}
+let Predicates = [HasAVX] in {
+def : Pat<(v4f32 (X86Movss
----------------
Should this be [UseAVX] and then add AVX512 patterns in X86InstrAVX512.td ?


================
Comment at: lib/Target/X86/X86InstrSSE.td:1994
+          (Int_VCVTSI2SDrr VR128:$dst, GR32:$src)>;
+}
+
----------------
It's more typical to put the AVX patterns before the SSE.


https://reviews.llvm.org/D28455





More information about the llvm-commits mailing list