[PATCH] D28444: Define sys::path::convert_to_slash.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 8 17:17:44 PST 2017
ruiu added a comment.
Sean,
I'm reluctant to change this type from `std::string convert_to_slashes(StringRef)` to `void convert_to_slashes(SmallVectorImpl<char> &)` as the former is easier to use than the latter. In some cases, you can avoid string copy with the latter type, but I think that's very important here. I don't want to optimize unless it is needed.
https://reviews.llvm.org/D28444
More information about the llvm-commits
mailing list