[PATCH] D28104: update TTI costs for arithmetic instructions on X86\SLM arch.

Mohammed Agabaria via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 8 01:35:38 PST 2017


magabari marked 10 inline comments as done.
magabari added a comment.

fixed Simon comments



================
Comment at: test/Analysis/CostModel/X86/slm-arith-costs.ll:1
+; RUN: opt < %s -cost-model -analyze -mcpu=slm | FileCheck %s --check-prefix=SLM
+
----------------
RKSimon wrote:
> Wouldn't it be better to try and add SLM as a check-prefix to existing cost test files?
I have checked but i think the test itself not covered in previous tests like arith.ll because the focus here is to  shrink the operands to small datatype.

some of the cases can be merged with arith.ll do you want me to merge those?


https://reviews.llvm.org/D28104





More information about the llvm-commits mailing list