[PATCH] D28203: Enable weak hooks on darwin

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 7 08:53:18 PST 2017


compnerd added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:35
 
-#if (SANITIZER_LINUX || SANITIZER_WINDOWS) && !SANITIZER_GO
+#if (SANITIZER_LINUX || SANITIZER_MAC || SANITIZER_WINDOWS) && !SANITIZER_GO
 # define SANITIZER_SUPPORTS_WEAK_HOOKS 1
----------------
kubabrecka wrote:
> What about FreeBSD?  Just curious.
I believe that FreeBSD uses ELF, so it should be able to support weak linkage.  However, if its untested ...


Repository:
  rL LLVM

https://reviews.llvm.org/D28203





More information about the llvm-commits mailing list