[PATCH] D28414: Simplify conditional branch on constant condition and remove unreachable blocks in LoopUnswitch.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 14:31:54 PST 2017


efriedma added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:1374
+        BI->eraseFromParent();
+        Worklist.push_back(NBI);
+      }
----------------
See the comment near the beginning of LoopUnswitch::TryTrivialLoopUnswitch for a description of all the state you aren't updating correctly.

Also, I think you meant "isa<ConstantInt>(BI->getCondition())".


https://reviews.llvm.org/D28414





More information about the llvm-commits mailing list