[PATCH] D23378: Explicitly specify MSVC mangling of iostream globals
Eric Fiselier via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 6 14:03:56 PST 2017
EricWF added a comment.
In https://reviews.llvm.org/D23378#638185, @kastiglione wrote:
> @EricWF I don't have commit access. Would you mind committing?
>
> > `cl` doesn't support `__asm__` so technically this patch is incorrect since `cl` defines `_MSC_VER`.
>
> Is it worth adding `&& defined(__clang__)`?
Up to you. Once we update clang to provide builtin macros for ABI detection we'll have to change all of these guards anyway.
https://reviews.llvm.org/D23378
More information about the llvm-commits
mailing list