[PATCH] D28075: MergeFunctions: Preserve debug info in thunks, under option -mergefunc-preserve-debug-info

[Anmol P. Paralkar via Phabricator via llvm-commits]

appcs added a comment.

In https://reviews.llvm.org/D28075#638292, @aprantl wrote:

> In https://reviews.llvm.org/D28075#638014, @appcs wrote:
>
> >
>
>
>
>
> >   What should -mergefunc-preserve-debug-info do about the thunk's call to the shared implementation?
> >   Mark as tail call or not? The existing -mergefunc behaviour is to mark it as a tail call. We could leave it as is,
> >   unless someone specifically asks for a change under -mergefunc-preserve-debug-info; would that be OK?
>
> I think marking it as a tail call makes most sense.


ACK; thanks.


https://reviews.llvm.org/D28075