[PATCH] D23652: [mips] N64 static relocation model support

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

@seanbruno Want to give this a try?



================
Comment at: lib/Target/Mips/Mips64InstrInfo.td:515
 
+def : MipsPat<(MipsJmpLink (i64 texternalsym:$dst)),
+              (JAL texternalsym:$dst)>;
----------------
zoran.jovanovic wrote:
> Nit: Is this definition necessary?
> If it is needed for micromips pre-r6 than it can be moved to MicroMipsInstrInfo.td.
It's not. It's covered by the multiclass below.


================
Comment at: lib/Target/Mips/MipsAsmPrinter.cpp:703
     //        For the moment, I'm only correcting enough to make MIPS-IV work.
     if (!isPositionIndependent() && !ABI.IsN64())
       TS.emitDirectiveOptionPic0();
----------------
zoran.jovanovic wrote:
> Is this condition also affected by the change?
Good catch. It requires !isPositionIndependant() && STI.hasSym32(), as pic0 only applies when symbols are 32 bit according to GCC.


https://reviews.llvm.org/D23652