[PATCH] D23378: Explicitly specify MSVC mangling of iostream globals

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added a comment.

This LGTM again. We're working on getting special builtin macros to detect which ABI is being used, but until then this patch seems correct.

@smeenai mentioned that `cl` doesn't support `__asm__` so technically this patch is incorrect since `cl` defines `_MSC_VER`. However libc++ cannot use `cl` currently due to usages of other constructs it doesn't support, such as `#include_next`, so I'm not worried about that now.

@kastiglione do you have commit access?


https://reviews.llvm.org/D23378