[PATCH] D23378: Explicitly specify MSVC mangling of iostream globals

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: src/iostream.cpp:18
+_ALIGNAS_TYPE (istream) _LIBCPP_FUNC_VIS char cin[sizeof(istream)]
+#if defined(_LIBCPP_MSVC)
+__asm__("?cin at __1@std@@3V?$basic_istream at DU?$char_traits at D@__1 at std@@@12 at A")
----------------
`_LIBCPP_MSVC` is definitely not correct. It's only defined for cl, not for clang (not even clang-cl), and cl doesn't even support `__asm__`.


https://reviews.llvm.org/D23378