[PATCH] D28254: [AArch64][CostModel] Improve cost for fsqrt intrinsics.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/AArch64/intrinsic-cost-model.ll:1
+; RUN: opt < %s -basicaa -slp-vectorizer -S -mtriple=aarch64-unknown-linux-gnu -mcpu=kryo | FileCheck %s
+
----------------
Not sure if you're interested but utils\update_test_checks.py could be used to auto-generate this.

Also, why call it intrinsic-cost-model.ll and not just sqrt.ll or intrinsics.ll ?


================
Comment at: test/Transforms/SLPVectorizer/AArch64/intrinsic-cost-model.ll:20
+  br i1 %or.cond20, label %if.then, label %return
+
+if.then:                                          ; preds = %entry
----------------
Since this is a SLPVectorizer test are you gaining anything by giving it a loop to vectorizer instead of (simpler) flat code?


================
Comment at: test/Transforms/SLPVectorizer/AArch64/intrinsic-cost-model.ll:44
+}
+
+declare double @llvm.sqrt.f64(double)
----------------
Add a float test?


https://reviews.llvm.org/D28254