[PATCH] D28358: [globalisel] Stop requiring -debug/-debug-only=registerbankinfo for assertions.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 04:40:53 PST 2017


dsanders added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/RegisterBankInfo.cpp:61-62
     assert(RegBanks[Idx] != nullptr && "Invalid RegisterBank");
     assert(!RegBanks[Idx]->isValid() &&
            "RegisterBank should be invalid before initialization");
+  }
----------------
Fixing the typo revealed that this assertion triggers on trunk because of the AlreadyInit mechanism. I've removed this assert because it's only true the first time <Target>RegisterBankInfo is constructed and because will never be true once D27809 lands.


https://reviews.llvm.org/D28358





More information about the llvm-commits mailing list