[PATCH] D28359: [compiler-rt] Use common static library for sanitizer_common.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added a comment.

Hi @kubabrecka ,
No, weak symbols are ignored on Windows (SANITIZER_WEAK_ATTRIBUTE is empty).
It only uses "pragma"(/alternatename..." for some optional functions with default implementation, like: "__sanitizer_malloc_hook", "__sanitizer_print_memory_profile". But this only works for functions that are statically linked to asan library, for example, when they are defined in other sanitizers.
We can't use that for sanitizer coverage, because functions could be defined on the user side, and should work when asan is a shared library (a dll in Windows).
Because of that I decided to decouple sanitizer coverage from asan, and make sanitizer coverage always a static library for Windows.


Repository:
  rL LLVM

https://reviews.llvm.org/D28359