[PATCH] D28272: ELF: Reserve space for copy relocations of read-only symbols in relro.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

LGTM, but you may want to wait for a while to give Rafael to take another look.



================
Comment at: lld/ELF/Symbols.h:297-300
+  OutputSection<ELFT> *getBssSectionForCopy() const {
+    assert(needsCopy());
+    return CopyIsInBssRelRo ? Out<ELFT>::BssRelRo : Out<ELFT>::Bss;
+  }
----------------
Do you have to inline this function? I think you added `#include "OutputSections.h"` for this function, but I don't want to add a new #include to this file to avoid cyclic inclusion.


https://reviews.llvm.org/D28272