[PATCH] D27792: IfConversion: Use reverse_iterator to simplify. NFC

Kyle Butt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 18:51:05 PST 2017


iteratee added a comment.

Are there any other concerns with this patch?



================
Comment at: lib/CodeGen/IfConversion.cpp:716-719
+  const MachineBasicBlock::reverse_iterator B1 = MBB1->rend();
+  const MachineBasicBlock::reverse_iterator B2 = MBB2->rend();
+  MachineBasicBlock::reverse_iterator E1 = MBB1->rbegin();
+  MachineBasicBlock::reverse_iterator E2 = MBB2->rbegin();
----------------
dblaikie wrote:
> auto?
I'd rather not here.


https://reviews.llvm.org/D27792





More information about the llvm-commits mailing list