[PATCH] D28303: Add iterator support to DWARFDie to allow child DIE iteration.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 15:57:17 PST 2017


clayborg added inline comments.


================
Comment at: unittests/DebugInfo/DWARF/DwarfGenerator.cpp:112
+void dwarfgen::DIE::setForceChildren() {
+  if (Die)
+    Die->setForceChildren(true);
----------------
dblaikie wrote:
> Is this conditional needed - or do we generally assume it's an invariant that the Die is non-null for most of the operations on dwarfgen::DIE?
I'll take the if out.


https://reviews.llvm.org/D28303





More information about the llvm-commits mailing list