[PATCH] D28359: [compiler-rt] Use common static library for sanitizer_common.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added a comment.

@aizatsky So, I think the key question here is this:

"Sanitizer_common only provides stateless functionalities, or it also includes some global data that we should ensure is only included once?"

In the first case, when it only include stateless functionalities, there is no problem if we duplicate the code in shared libraries (for static libraries we can't, the linker will complain).
In the second case, it includes global data that should be unique, I think we should considered what I suggested before, removing that code from shared libraries, and only including it in the static library.


Repository:
  rL LLVM

https://reviews.llvm.org/D28359