[PATCH] D27114: Preserve nonnull metadata on Loads through SROA & mem2reg.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 12:49:26 PST 2017


efriedma added a comment.

> Apologies if this isn't directly related to this patch, but one thing I noticed and mentioned in https://reviews.llvm.org/D28337: InstCombine is not calling into InstSimplify (and hence value tracking) with a context instruction in many cases. And so computeKnownBitsFromAssume() is not triggered in those cases. If we fix that (assuming that the lack of context instruction optional parameter is an oversight), we should make better use of the assumption machinery.

I was more referring to the fact than m_OneUse etc. doesn't work the way you want it to in the presence of llvm.assume calls.


https://reviews.llvm.org/D27114





More information about the llvm-commits mailing list