[PATCH] D27963: [Codegen] Have the generic debug skip functions return true on empty.
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 5 12:02:56 PST 2017
MatzeB requested changes to this revision.
MatzeB added a reviewer: MatzeB.
MatzeB added a comment.
This revision now requires changes to proceed.
I'm not in favor of this. Reference parameters (that actually change a variable) are non obvious and should mostly be avoided in C++.
At least to me it is also not obvious what that return value is when seeing the name `skipDebugInstructionsForward`.
Repository:
rL LLVM
https://reviews.llvm.org/D27963
More information about the llvm-commits
mailing list