[PATCH] D28363: [LICM] Small update to note changes made in hoistRegion

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 11:01:20 PST 2017


andrew.w.kaylor added a comment.

In https://reviews.llvm.org/D28363#637147, @mkuper wrote:

> (Out of curiosity - you mean r290726 actually has an observable effect on compile time?)


I hadn't gotten as far as taking measurements.  I did find a file in a spec test where the LCSSA form was being unnecessarily recomputed 43 times, but it was probably relatively quick since nothing needed to change.

LICM was showing up as a time consuming pass on a couple of measurements that were sent my way, so my first step was just reading through the code and looking for anything obvious that could be fixed easily.  The two things I saw were the issue you addressed in r290726 and the funclet coloring thing I e-mailed you about.


Repository:
  rL LLVM

https://reviews.llvm.org/D28363





More information about the llvm-commits mailing list