[PATCH] D27114: Preserve nonnull metadata on Loads through SROA & mem2reg.

[Luqman Aden via Phabricator via llvm-commits]

luqmana added a comment.

In https://reviews.llvm.org/D27114#637151, @efriedma wrote:

> > I want to make sure Eli is happy with this approach w.r.t. any semantic differences between !nonnull metadata and the assume. Haven't seen an update from him since the switch of formulation.
>
> Semantically, this seems consistent with existing code dealing with !nonnull.  That said, creating calls to `@llvm.assume` has the potential to cause performance regressions; there are a bunch of places in the optimizer which don't handle them well, so it's probably worth checking that this change doesn't create more problems than it solves.


Are there any existing performance tests so I can determine if this might cause a regression?


https://reviews.llvm.org/D27114