[PATCH] D27997: [AMDGPU] Prevent spills before exec mask is restored

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D27997#637109, @MatzeB wrote:

> Ok so if I understand this correctly the dependencies are actually visible by means of defs/uses of some mask register, this only affects spill placement code just because it is not obvious that a spill instruction will read the mask register and before actually creating it?


Yes.

> I don't like the name `isPositionLike()`. The semantic do not seem to be too similar to `isPosition()` which are instructions that mark a place in a function that is somehow visible elsewhere (because of exception handling tables, ...), this is not the case here.

Will the "isBasicBlockPrologue()" name be better?

> Also if the only use of this function is fixing a spill code placement problem, then the documentation comment should mention that.

OK, will add comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D27997