[PATCH] D28363: [LICM] Small update to note changes made in hoistRegion

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 09:32:45 PST 2017


andrew.w.kaylor created this revision.
andrew.w.kaylor added a reviewer: mkuper.
andrew.w.kaylor added a subscriber: llvm-commits.
andrew.w.kaylor set the repository for this revision to rL LLVM.

I'm not sure how important this is, but I think the code was technically incorrect without it.

I was looking at LICM to see if I could improve compilation time.  The easiest thing I found turned out to have been fixed last week with r290726.  This one liner was all that was left of a patch I was working on. :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D28363

Files:
  lib/Transforms/Scalar/LICM.cpp


Index: lib/Transforms/Scalar/LICM.cpp
===================================================================
--- lib/Transforms/Scalar/LICM.cpp
+++ lib/Transforms/Scalar/LICM.cpp
@@ -408,6 +408,7 @@
           CurAST->deleteValue(&I);
           I.eraseFromParent();
         }
+        Changed = true;
         continue;
       }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28363.83265.patch
Type: text/x-patch
Size: 330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170105/3f907d28/attachment.bin>


More information about the llvm-commits mailing list