[PATCH] D23378: Explicitly specify MSVC mangling of iostream globals
Eric Fiselier via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 4 22:50:59 PST 2017
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus inline coments.
@majnemer suggested another solution that would work with both MSVC and clang-cl but Libc++ is far from being able to support MSVC (due to `#include_next`), so this fix is good for now.
Unfortunately this is going to become more difficult to maintain once libc++ starts using different versioning namespaces. However we can cross that bridge when we come to it.
https://reviews.llvm.org/D23378
More information about the llvm-commits
mailing list