[PATCH] D27993: [libFuzzer] Diff 44 - Update cmake for libFuzzer. Remove requiring LLVM_USE_SANITIZE_COVERAGE .

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 19:09:15 PST 2017


kcc added a comment.

In https://reviews.llvm.org/D27993#636403, @mpividori wrote:

> @kcc  exactly, because these are different build config:
>
>   + The purpose of `LLVM_USE_SANITIZE_COVERAGE` is to active the coverage flags for all the repository.
>   + The purpose of `ENABLE_LIBFUZZER` is to avoid automatically building libFuzzer with a non fresh clang compiler, which would fail.
>
> Also, I could automatical set `ENABLE_LIBFUZZER=true` when `LLVM_USE_SANITIZE_COVERAGE=true`.
>
> Anyway, the main intention of these changes is to make it work on Windows. If you prefer, I can continue using only `LLVM_USE_SANITIZE_COVERAGE` and remove dependency on FileCheck (win-only) and rely on having it in PATH.


Yes, that would be a simpler med-term solution.

In https://reviews.llvm.org/D27993#636403, @mpividori wrote:

> @kcc  exactly, because these are different build config:
>
>   + The purpose of `LLVM_USE_SANITIZE_COVERAGE` is to active the coverage flags for all the repository.
>   + The purpose of `ENABLE_LIBFUZZER` is to avoid automatically building libFuzzer with a non fresh clang compiler, which would fail.
>
> Also, I could automatical set `ENABLE_LIBFUZZER=true` when `LLVM_USE_SANITIZE_COVERAGE=true`.
>
> Anyway, the main intention of these changes is to make it work on Windows. If you prefer, I can continue using only `LLVM_USE_SANITIZE_COVERAGE` and remove dependency on FileCheck (win-only) and rely on having it in PATH.





Repository:
  rL LLVM

https://reviews.llvm.org/D27993





More information about the llvm-commits mailing list