[PATCH] D28175: [GlobalISel] Fix AArch64 ICMP instruction selection

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Kristof,

LGTM.
Nitpicks below.

Thanks,
-Quentin



================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:1079
 
-    const AArch64CC::CondCode CC = changeICMPPredToAArch64CC(
-        (CmpInst::Predicate)I.getOperand(1).getPredicate());
+    const AArch64CC::CondCode invCC = changeICMPPredToAArch64CC(
+      CmpInst::getInversePredicate(
----------------
Could you add a comment why we do this?
Exactly what you said in the summary of the patch would be good.


https://reviews.llvm.org/D28175