[PATCH] D28079: [GlobalISel] Add support for indirectbr

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi,

Regarding (G)MIR vs. (T)MIR or whatever, I would stick to MIR for intermediate MachineInstr representation without generic opcode and Generic MachineInstr (or GMIR) when generic opcode are present. The story behind (G)MIR is that this is a*always* a target specific representation (because MachineInstr are always bound to a target) but can optionally (thus parenthesis) contain generic opcodes.

Therefore the difference between (G)MIR and MIR is the latter cannot have generic opcodes whereas the former can, but again in both cases the representation is target depend.

The bottom line is please don't add another naming convention.

Cheers,
-Quentin


https://reviews.llvm.org/D28079