[PATCH] D28251: [AArch64] Fix over-eager early-exit in load-store combiner

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added a comment.

This change LGTM. As Chad mention, it will be good to add a clear test case which specially shows the case handled by this change like the one from Chad's comment.



================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1474
+  if (Offset > 0)
+    Offset -= OffsetStride;
   if (!inBoundsForPair(IsUnscaled, Offset, OffsetStride))
----------------
It will be good to have a comment explaining the case handled by doing this. 


https://reviews.llvm.org/D28251