[PATCH] D28265: disable sigaltstack on Apple platforms

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: config-ix.cmake:170-171
 # AddressSanitizer conflicts with lib/Support/Unix/Signals.inc
-if( HAVE_SIGNAL_H AND NOT LLVM_USE_SANITIZER MATCHES ".*Address.*")
+# and backtraces do not work on Apple platforms when using sigaltstack.
+if( HAVE_SIGNAL_H AND NOT LLVM_USE_SANITIZER MATCHES ".*Address.*" AND NOT APPLE )
   check_symbol_exists(sigaltstack signal.h HAVE_SIGALTSTACK)
----------------
davide wrote:
> Just a small request: can you you expand this comment a little more? A condensed version of your comment would be excellent, ideally we should have a reference to something publicly accessing, but, that lacking a reference to the rdar is probably fine).
*publicly accessible


https://reviews.llvm.org/D28265