[PATCH] D28236: InstCombine: Fold cos(-x) -> cos(x)

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 09:19:41 PST 2017


davide added a comment.

In https://reviews.llvm.org/D28236#635393, @arsenm wrote:

> Getting back on topic, is there any objection to doing this optimization for the intrinsic (and for llvm.amdgcn.cos) separately here?


I think this is fine but if we go this route the code in `SimplifyLibCalls` should be removed and we should always lower there to `@llvm.cos` (as we do already for other intrinsics, FWIW, e.g. `@llvm.fls`)


https://reviews.llvm.org/D28236





More information about the llvm-commits mailing list